Tim Armstrong has posted comments on this change. Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7154/1/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: PS1, Line 764: children_.size() > What about this? The reserve() shouldn't matter for correctness, but this is wonky. Maybe we should just get rid of this line - I doubt avoiding an allocation or two on this code makes any measurable difference. -- To view, visit http://gerrit.cloudera.org:8080/7154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fad4ee2eee1f73e387c1e90a3db265b19b3a0c6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
