Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift() ......................................................................
IMPALA-5487: Fix race in RuntimeProfile::toThrift() node.num_children got initialized before children_ was locked. This could lead to node.num_children < children_.size(), which made the node tree in the resulting thrift profiles not deserialize properly. To fix this, node.num_children needs to be initialized after children_ has been locked. I tested this by running queries on a private cluster for a while, making sure that the thrift profiles of running queries could be parsed correctly. Change-Id: I7fad4ee2eee1f73e387c1e90a3db265b19b3a0c6 Reviewed-on: http://gerrit.cloudera.org:8080/7154 Reviewed-by: Dan Hecht <dhe...@cloudera.com> Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Reviewed-by: Sailesh Mukil <sail...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/util/runtime-profile.cc 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Impala Public Jenkins: Verified Sailesh Mukil: Looks good to me, but someone else must approve Tim Armstrong: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fad4ee2eee1f73e387c1e90a3db265b19b3a0c6 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
