Lars Volker has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs ......................................................................
Patch Set 4: (2 comments) Thanks for the comments. Please see PS5. http://gerrit.cloudera.org:8080/#/c/7155/3/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: PS3, Line 291: } : } > the write of this doesn't look like it's done under the lock, so no point o Done PS3, Line 294: // Add warnings from analysis : error_log_ss << join(request_state->GetAnalysisWarnings(), "\n"); : : // Add warnings from execution : if (request_state->coord() != nullptr) { : if (!request_state->que > I think we shouldn't hold the lock across this since it should be synchroni Done -- To view, visit http://gerrit.cloudera.org:8080/7155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
