Lars Volker has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs ......................................................................
Patch Set 5: -Verified (2 comments) It looks like I ran the tests against the wrong binary. On my dev machine I maintain different worktrees and switching between them did not update the binary path. Added the DCHECK you suggested nonetheless, but I my failures were false alarms. I'm looping the test with correct binaries now. http://gerrit.cloudera.org:8080/#/c/7155/5/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 253: lock_guard<mutex> l(*request_state->lock()); > you could add a DCHECK() here that if query_state == EXCEPTION, then !query Done Line 299: lock_guard<mutex> l(*request_state->lock()); > rather than retaking the lock here, you should remember the value of ok() f Done -- To view, visit http://gerrit.cloudera.org:8080/7155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
