Tim Armstrong has posted comments on this change. Change subject: IMPALA-5567: race in fragment instance teardown ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7275/1/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: Line 102: ScalarExprEvaluator::FreeLocalAllocations(output_expr_evals_); > Not your change but should we check for query status here too ? I can imagi Done PS1, Line 150: DCHECK( > DCHECK_GE() Done http://gerrit.cloudera.org:8080/#/c/7275/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: PS1, Line 294: /// Returns a non-OK status if query execution should stop (e.g., the query was : /// cancelled or a mem limit was exceeded). Exec nodes should check this periodically so : /// execution doesn't continue if the query terminates abnormally. This should not be : /// called after ReleaseResources(). : Status CheckQueryState(); > I think this method is confusing to begin with, which probably led us to mi How about we rename them to be less vague. Maybe something like: CheckQueryState() -> CheckMemLimitOrAsyncError() GetQueryStatus() -> CheckAsyncError() query_status_ -> async_error_status_ -- To view, visit http://gerrit.cloudera.org:8080/7275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If567e734042b5f2b82323368dd536dbf3bdf4744 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
