Tim Armstrong has posted comments on this change. Change subject: IMPALA-5567: race in fragment instance teardown ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7275/2/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: Line 101: results_ = nullptr; > At first glance this looks reasonable to put here, but is this necessary fo I don't feel strongly. I think the idea was to move these status checks more closely to the expr evaluations that could cause errors to be hit. http://gerrit.cloudera.org:8080/#/c/7275/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: PS1, Line 294: /// Returns a non-OK status if query execution should stop (e.g., the query was : /// cancelled or a mem limit was exceeded). Exec nodes should check this periodically so : /// execution doesn't continue if the query terminates abnormally. This should not be : /// called after ReleaseResources(). : Status CheckQueryState(); > I like CheckAsyncError() for GetQueryStatus(). If we can convert all of the I think we should do the work of removing Allocate() calls at some point but I think we should keep fix as targeted as possible. That might be an argument to defer doing the rename as well. -- To view, visit http://gerrit.cloudera.org:8080/7275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If567e734042b5f2b82323368dd536dbf3bdf4744 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
