Jim Apple has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/7179/4/shell/option_parser.py File shell/option_parser.py: PS4, Line 88: Queries read from stdin and end with ctrl+d " : "if the argument to -f is -. Try "If the argument to -f is "-", then queries are read from stdin and terminated with ctrl-d." PS4, Line 163: has character of a-z or A-Z at the beginning "starts with an alphabetic character" PS4, Line 164: characters of a-z or A-Z and/or numbers. "only alphanumeric characters." -- To view, visit http://gerrit.cloudera.org:8080/7179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-HasComments: Yes
