Donghui Xu has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option ......................................................................
Patch Set 6: (1 comment) I hava added description about underscores. Than you. http://gerrit.cloudera.org:8080/#/c/7179/5/shell/option_parser.py File shell/option_parser.py: Line 164: " contains alphanumeric characters or underscores.") > This actually is incorrect - it can also contain underscores. Sorry for missing underline. -- To view, visit http://gerrit.cloudera.org:8080/7179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-HasComments: Yes