Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes ......................................................................
IMPALA-5618: buffered-tuple-stream-v2 fixes This fixes two issues: * AddRowCustom() caused a performance regression when the function was heap-allocated. This is solved by splitting the API into two separate calls. This imposes an additional burden on the caller but it is easier to reason about its performance. * Allow re-reading streams with 'delete_on_read_' set so long as no rows were read from the stream. This is necessary for some spilling ExecNodes that prepare the stream for reading in order to acquire the buffer, but then need to spill the stream to free memory before they actually are able to read the stream. Change-Id: Ibab0d774f66be632f17376a56abf302821cca047 --- M be/src/runtime/buffered-tuple-stream-v2-test.cc M be/src/runtime/buffered-tuple-stream-v2.cc M be/src/runtime/buffered-tuple-stream-v2.h M be/src/runtime/buffered-tuple-stream-v2.inline.h 4 files changed, 82 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/7358/4 -- To view, visit http://gerrit.cloudera.org:8080/7358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibab0d774f66be632f17376a56abf302821cca047 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
