Tim Armstrong has posted comments on this change. Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7358/3/be/src/runtime/buffered-tuple-stream-v2.h File be/src/runtime/buffered-tuple-stream-v2.h: Line 284: /// Called after AddRowCustomBegin(). See the AddRowCustomBegin() comment for > i suppose this doesn't/shouldn't be called if AddRowCustomBegin() returns n Done PS3, Line 540: AddRowCustomEndSlow > the name makes it sound like this is symmetric to AddRowCustomBeginSlow(), Works for me -- To view, visit http://gerrit.cloudera.org:8080/7358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibab0d774f66be632f17376a56abf302821cca047 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
