Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7332/3/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: PS3, Line 42: ( nit space http://gerrit.cloudera.org:8080/#/c/7332/3/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: Line 25: from __builtin__ import any as b_any why is this necessary? PS3, Line 129: 10 why not just 1 second? PS3, Line 156: # Sleep for 15 seconds and make sure that the privileges : # on all 3 tables still persist on a sentryProxy thread : # update. sentry_catalog_polling_frequency is set to 10 : # seconds. : sleep(15) I wonder if we can lower this if we reduce the sentry polling freq. Even a 15 sec wait is unfortunate in our already long running tests -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
