Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7332/3/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: Line 25: from __builtin__ import any as b_any > why is this necessary? It shouldn't be unless any is shadowed, which it ought not be. If it is, that should be fixed. any has been a builtin library function since python 2.5. PS3, Line 143: grant_rev_db > Looks like a common db name used in authz tests. Could you randomize it? El I suggest using the unique_database fixture instead of creating databases and having a use side-effect command. "git grep unique_database" for examples. -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
