Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size ......................................................................
Patch Set 7: I did a pass and think it makes sense. Took me a while just to page the code back in, hadn't looked at the DiskIoMgr in a while. I appreciate the simplification here :) I'd like to look again when I'm fresh later this week, since it sounds like this isn't holding anything up. Would you mind adding a timer to measure how much time is spent waiting on the consumer? -- To view, visit http://gerrit.cloudera.org:8080/7408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7cc3f7199f5320db00b7face97a96cdadb6f83f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No
