Balazs Jeszenszky has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7721/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: Line 151: summary_profile_.AddInfoString("Query Options (non default, after planning)", > this is probably okay, but i wonder if it'd be clearer if we instead either I'd change 'before planning' and 'after planning' to 'manually set' and 'planner set', and make the lists mutually exclusive. If mutually exclusive isn't worth it, 'after planning' could be called 'including planner set'. -- To view, visit http://gerrit.cloudera.org:8080/7721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
