Dan Hecht has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7721/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: PS3, Line 149: manually > Hm. This word may be misleading, query options may have been set when assig That's a good point. Also, referring to these as "non-default" can be confusing given that the startup flag is called --default_query_options, and so you might expect this list to include the values that are different from those. I don't have a great suggestion right now though. Ideas? -- To view, visit http://gerrit.cloudera.org:8080/7721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
