Joe McDonnell has posted comments on this change. Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8056/1/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: Line 68 Avoid unrelated whitespace diffs. One way of getting a graphical diff that can help with this is to use the tool meld. For example: git difftool -y -t meld <branch> <file> Where <branch> could be asf-gerrit/master or origin/master or whatnot. PS1, Line 96: fq_tbl_name = "functional_parquet" + "." + tbl_name I'm wary of creating tables in our default schemas. This won't get cleaned up, and it is subtle behavior. If we can create the new table in the unique_database that would be nice PS1, Line 98: create = ("create table {0} stored as parquet as select * from functional.alltypes" : .format(fq_tbl_name)) I think we need to verify that the right options are being set when we create this table. As I understand it, you need to specify the query option compression_codec = none to create a parquet file without compression. https://www.cloudera.com/documentation/enterprise/5-8-x/topics/impala_compression_codec.html -- To view, visit http://gerrit.cloudera.org:8080/8056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-HasComments: Yes
