Pranay Singh has posted comments on this change. Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8056/1/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: Line 68 > Avoid unrelated whitespace diffs. Thanks I was able to fix this issue PS1, Line 96: fq_tbl_name = "functional_parquet" + "." + tbl_name > I'm wary of creating tables in our default schemas. This won't get cleaned Shall I drop the table after running fuzz test ? PS1, Line 98: create = ("create table {0} stored as parquet as select * from functional.alltypes" : .format(fq_tbl_name)) > I think we need to verify that the right options are being set when we crea I introduced a check that compression_codec == none is only used here line #93 -- To view, visit http://gerrit.cloudera.org:8080/8056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-HasComments: Yes
