Dan Hecht has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7731/3/common/thrift/CatalogInternalService.thrift File common/thrift/CatalogInternalService.thrift: PS3, Line 34: updated does "updated" also include new objects? or is it really just objects that have been updated, i.e. changed? http://gerrit.cloudera.org:8080/#/c/7731/3/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: PS3, Line 86: deleted in this case, what is in 'value'? Is it defined to be set or is only the key relevant? (Your commit message talks about it but it's not clear from the interface). PS3, Line 103: all changes your commit message seems to contradict that. Oh, maybe i'm confusing catalog versions and statestore topic versions? PS3, Line 105: The from_version will always be 0 for non-delta updates what about to_version in this case? -- To view, visit http://gerrit.cloudera.org:8080/7731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93cb7a033dc8f0d3e0339394b36affe14523274c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-HasComments: Yes
