Dan Hecht has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7731/3/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: PS3, Line 86: deleted > What I tried to explain in the commit msg (let me know if it still unclear) What I meant is that we should explain in the comment here what 'value' means when 'deleted'=true. it doesn't seem intuitive what 'value' would be in that case (in most systems, "delete" operations deal only with the 'key' not the 'value'). PS3, Line 105: The from_version will always be 0 for non-delta updates > The to_version is 0 only when there are no changes in the topic. It's value Yeah. what I meant was we should document it in this comment, right? -- To view, visit http://gerrit.cloudera.org:8080/7731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93cb7a033dc8f0d3e0339394b36affe14523274c Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-HasComments: Yes
