Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-5895: clean up runtime profile lifecycle ......................................................................
IMPALA-5895: clean up runtime profile lifecycle Require callers to explicitly stop counter updating instead of doing it in the destructor. This replaces ad-hoc logic to stop individual counters. Track which counters need to be stopped in separate lists instead of stopping everything. Force all RuntimeProfiles to use ObjectPools in a uniform way - the profile, its counters and its children all are allocated from the same pool. This is done via a new Create() method. Change-Id: I45c39ac36c8e3c277213d32f5ae5f14be6b7f0df --- M be/src/benchmarks/hash-benchmark.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/data-sink.cc M be/src/exec/data-source-scan-node.cc M be/src/exec/exec-node.cc M be/src/exec/exec-node.h M be/src/exec/hash-table-test.cc M be/src/exec/hbase-scan-node.cc M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h M be/src/exec/kudu-scan-node-base.cc M be/src/exec/kudu-scan-node-base.h M be/src/exec/kudu-scan-node-mt.cc M be/src/exec/scan-node.cc M be/src/exec/scan-node.h M be/src/experiments/data-provider-test.cc M be/src/experiments/tuple-splitter-test.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/bufferpool/buffer-allocator-test.cc M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/reservation-tracker-test.cc M be/src/runtime/bufferpool/suballocator-test.cc M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/data-stream-recvr.cc M be/src/runtime/data-stream-recvr.h M be/src/runtime/data-stream-test.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/query-state.cc M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-server.cc M be/src/util/dummy-runtime-profile.h M be/src/util/periodic-counter-updater.cc M be/src/util/periodic-counter-updater.h M be/src/util/runtime-profile-test.cc M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h 43 files changed, 442 insertions(+), 417 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/8069/6 -- To view, visit http://gerrit.cloudera.org:8080/8069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I45c39ac36c8e3c277213d32f5ae5f14be6b7f0df Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
