Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/8069/8//COMMIT_MSG Commit Message: Line 19: Could you document that you removed the time_series_counter_map_lock_ and the reasoning? http://gerrit.cloudera.org:8080/#/c/8069/8/be/src/exec/data-sink.cc File be/src/exec/data-sink.cc: PS8, Line 178: profile_ How come we don't stop counters for this profile? There are other profiles in other files where we don't stop them too. Wouldn't that be a slight change in behavior? Since they were previously stopped in the destructor? http://gerrit.cloudera.org:8080/#/c/8069/8/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: PS8, Line 950: vector<RuntimeProfile::Counter*>* RuntimeProfile::AddBucketingCounters(Counter* src_counter, Long line -- To view, visit http://gerrit.cloudera.org:8080/8069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c39ac36c8e3c277213d32f5ae5f14be6b7f0df Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
