Tim Armstrong has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/8069/9/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: PS9, Line 368: PeriodicCounterUpdater::StopRateCounter(total_throughput_counter()); : PeriodicCounterUpdater::StopTimeSeriesCounter(bytes_read_timeseries_counter_); > Spurious. These should be stopped in ScanNode::Close() ? Good point, I missed those. http://gerrit.cloudera.org:8080/#/c/8069/9/be/src/runtime/data-stream-recvr.cc File be/src/runtime/data-stream-recvr.cc: PS9, Line 244: PeriodicCounterUpdater::StopTimeSeriesCounter( : recvr_->bytes_received_time_series_counter_); > Seems like an outlier. Good point. I released that we didn't actually call StopPeriodicCounters() on the profile_ here, which made me realise there was a bug in AddTimeSeriesCounter() where the flag wasn't set. -- To view, visit http://gerrit.cloudera.org:8080/8069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c39ac36c8e3c277213d32f5ae5f14be6b7f0df Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
