Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message: PS9, Line 29: For request_pool, this means that setting the default : request_pool via impalad command line is now a bad idea > could you check with MJ about whether people do that? I get the feeling tha I don't have data to back this up, but I'd guess that some folks are probably doing it even though it isn't the right thing to do (they should use the "default" placement rule to map specifically into the default pool.) The case that might break is when a user has: a) placement rules set up like "1) specified, 2) anything else, e.g. 'default' or 'user'" b) they set --default_query_options=request_pool=foo c) then rely on manually setting the session query option request_pool="" to get the mapping defined by the 2nd placement rule. That said, I think this is a bad practice so I wouldn't be opposed to fixing this as long as we clearly release note it, and perhaps issue a warning if starting up the impala server with default_query_options=request_pool=foo -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
