Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 )
Change subject: IMPALA-5908: Allow SET to unset modified query options. ...................................................................... Patch Set 10: Code-Review+1 (1 comment) Tim, since you were a reviewer on the first go around, would you like to take a look at the fixed version of this change? http://gerrit.cloudera.org:8080/#/c/8070/9/tests/custom_cluster/test_set_and_unset.py File tests/custom_cluster/test_set_and_unset.py: http://gerrit.cloudera.org:8080/#/c/8070/9/tests/custom_cluster/test_set_and_unset.py@52 PS9, Line 52: # Use a "request overlay" to change the option for a specific : # request within a session. We run a r > I updated the comment. And added another test case. Which failed, so I upda What do you want to do about this? I'm okay with submitting this patch as-is, but if you think there's something that would be better, that's okay too. -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-Change-Number: 8070 Gerrit-PatchSet: 10 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2017 00:15:18 +0000 Gerrit-HasComments: Yes