Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8169 )
Change subject: IMPALA-5994: Failure in star expansion on struct fields ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8169/1/fe/src/main/java/org/apache/impala/catalog/StructField.java File fe/src/main/java/org/apache/impala/catalog/StructField.java: http://gerrit.cloudera.org:8080/#/c/8169/1/fe/src/main/java/org/apache/impala/catalog/StructField.java@37 PS1, Line 37: // Impala expects column names to be lower cased, but this is not always true for > Can you add a brief comment why we need to do this? Done http://gerrit.cloudera.org:8080/#/c/8169/1/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/8169/1/tests/query_test/test_nested_types.py@96 PS1, Line 96: rCase > nit: This seems easy to miss. Can you pick something more obvious, like cam Done http://gerrit.cloudera.org:8080/#/c/8169/1/tests/query_test/test_nested_types.py@100 PS1, Line 100: U > Does the uppercase F matter here? Not really. This query passed even before the fix, just adding a little extra coverage while I'm here. -- To view, visit http://gerrit.cloudera.org:8080/8169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacd9714ac2301a55ee8b64f0102f6f156fb0370e Gerrit-Change-Number: 8169 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Sep 2017 22:27:05 +0000 Gerrit-HasComments: Yes
