Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8169 )
Change subject: IMPALA-5994: Failure in star expansion on struct fields ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/8169/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8169/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-5994: Failure in star expansion on struct fields Commit msg should describe the change/fix, not the symptom of the bug. For example this would be clearer: IMPALA-5994: Lower case struct-field names http://gerrit.cloudera.org:8080/#/c/8169/2/fe/src/main/java/org/apache/impala/catalog/StructField.java File fe/src/main/java/org/apache/impala/catalog/StructField.java: http://gerrit.cloudera.org:8080/#/c/8169/2/fe/src/main/java/org/apache/impala/catalog/StructField.java@37 PS2, Line 37: // Impala expects column names to be lower cased, but this is not always true for // Impala expects field names to be in lower case, but type strings stored in the HMS are not guaranteed to be lower case. (no need to mention JIRA imo) -- To view, visit http://gerrit.cloudera.org:8080/8169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacd9714ac2301a55ee8b64f0102f6f156fb0370e Gerrit-Change-Number: 8169 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Sep 2017 23:14:05 +0000 Gerrit-HasComments: Yes
