Hello Michael Ho, Joe McDonnell, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8074 to look at the new patch set (#2). Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala ...................................................................... IMPALA-5174: Suppress kudu flags that aren't relevant to Impala Importing Kudu's util/, security/ and rpc/ code into the Impala code base results in Kudu's gflags showing up in the log files and the /varz webpages, for all the gflags that belong to Kudu files that are in some way used by Impala. For eg: If in Impala, we include kudu/rpc/messenger.h and use one of its classes whose method definitions live in the corresponding messenger.cc file, all the flags DEFINEd in the messenger.cc file will show up in the Impala logs. If we do not use any code in a .cc file, the flags that are DEFINEd in that file do not show up (this is probably due to the compiler not running macros in files that have only dead code). Since we don't want these flags to be user configurable, we don't want them to be visible. The following commit earlier included a gflags patch that added a DEFINE_*_hidden() macro that allows us to do just this: https://github.com/apache/incubator-impala/commit/d1910a39fcc50ce211b95c3552c0c90b4bc37bbd This patch was done by running the following sed command: find $IMPALA_HOME/be/src/kudu -type f | xargs sed -i 's/^\(DEFINE_.*\)\((.*\)/\1_hidden\2/g' There were a couple non-related macros that also got changed: DEFINE_validator() and DEFINE_STATIC_THREAD_LOCAL(), which were manually changed back. Change-Id: I499c903cde92595c4a02803ecbf98ac1d41517b4 --- M be/src/kudu/rpc/acceptor_pool.cc M be/src/kudu/rpc/messenger.cc M be/src/kudu/rpc/negotiation-test.cc M be/src/kudu/rpc/negotiation.cc M be/src/kudu/rpc/outbound_call.cc M be/src/kudu/rpc/reactor.cc M be/src/kudu/rpc/result_tracker.cc M be/src/kudu/rpc/rpc-bench.cc M be/src/kudu/rpc/rpc_stub-test.cc M be/src/kudu/rpc/rpcz_store.cc M be/src/kudu/rpc/server_negotiation.cc M be/src/kudu/rpc/service_if.cc M be/src/kudu/rpc/service_queue-test.cc M be/src/kudu/rpc/transfer.cc M be/src/kudu/security/tls_context.cc M be/src/kudu/security/token_signer.cc M be/src/kudu/util/cache.cc M be/src/kudu/util/debug/trace_event_impl.cc M be/src/kudu/util/env_posix.cc M be/src/kudu/util/env_util.cc M be/src/kudu/util/file_cache-stress-test.cc M be/src/kudu/util/file_cache.cc M be/src/kudu/util/flag_tags-test.cc M be/src/kudu/util/flag_validators-test.cc M be/src/kudu/util/flags-test.cc M be/src/kudu/util/flags.cc M be/src/kudu/util/kernel_stack_watchdog.cc M be/src/kudu/util/logging.cc M be/src/kudu/util/maintenance_manager.cc M be/src/kudu/util/memory/arena-test.cc M be/src/kudu/util/memory/memory.cc M be/src/kudu/util/metrics.cc M be/src/kudu/util/minidump.cc M be/src/kudu/util/mt-hdr_histogram-test.cc M be/src/kudu/util/mt-metrics-test.cc M be/src/kudu/util/mutex.cc M be/src/kudu/util/net/dns_resolver.cc M be/src/kudu/util/net/net_util.cc M be/src/kudu/util/net/socket.cc M be/src/kudu/util/nvm_cache.cc M be/src/kudu/util/process_memory.cc M be/src/kudu/util/spinlock_profiling.cc M be/src/kudu/util/striped64-test.cc M be/src/kudu/util/test_main.cc M be/src/kudu/util/test_util.cc 45 files changed, 117 insertions(+), 117 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/8074/2 -- To view, visit http://gerrit.cloudera.org:8080/8074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I499c903cde92595c4a02803ecbf98ac1d41517b4 Gerrit-Change-Number: 8074 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com>