Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8074 )
Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Rebase, carry +2. http://gerrit.cloudera.org:8080/#/c/8074/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8074/1//COMMIT_MSG@12 PS1, Line 12: in some way used by Impal > Only gflags in .cc files which aren't dead code will show up, right ? Pleas Yes, that's right. That's what I found in my experiments. I've updated the commit message. -- To view, visit http://gerrit.cloudera.org:8080/8074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I499c903cde92595c4a02803ecbf98ac1d41517b4 Gerrit-Change-Number: 8074 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Oct 2017 04:14:38 +0000 Gerrit-HasComments: Yes