Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 )
Change subject: IMPALA-5789: Add always_false flag in bloom filter ...................................................................... Patch Set 3: (6 comments) This is definitely going to conflict with my patch, but you should be able to get this in first so I'll probably have to do the painful rebasing. http://gerrit.cloudera.org:8080/#/c/8170/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8170/3//COMMIT_MSG@13 PS3, Line 13: Testing I assume you ran the existing runtime filter tests? http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/common/global-flags.cc@129 PS3, Line 129: order to provide a regression test for IMPALA-3798 and a test for IMPALA-5789. This is a little cluttered. I think its okay to just say "for testing purposes" and anyone who wants to know the exact JIRAs can easily grep for uses of it. http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/exec/filter-context.h File be/src/exec/filter-context.h: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/exec/filter-context.h@129 PS3, Line 129: HasAlwaysFalseInList I think this needs to be renamed for two reasons: - We're eventually going to be adding 'in-list' filters (in addition to the existing "bloom" and soon "min-max" filters), so the "InList" here is potentially confusing. - Its unusual for a function starting with "Has" to have side effects (incrementing the stats). Maybe "CheckForAlwaysFalse"? Or something better you come up with. http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/runtime/runtime-filter.inline.h File be/src/runtime/runtime-filter.inline.h: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/runtime/runtime-filter.inline.h@53 PS3, Line 53: return bloom_filter_ != BloomFilter::ALWAYS_TRUE_FILTER && : bloom_filter_->AlwaysFalse(); single line? http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/util/bloom-filter.h@111 PS3, Line 111: hasn't been inserted any elements hasn't had any elements inserted http://gerrit.cloudera.org:8080/#/c/8170/3/tests/custom_cluster/test_always_false_filter.py File tests/custom_cluster/test_always_false_filter.py: http://gerrit.cloudera.org:8080/#/c/8170/3/tests/custom_cluster/test_always_false_filter.py@34 PS3, Line 34: impalad = self.cluster.get_any_impalad() : client = impalad.service.create_beeswax_client() I think you can just add 'cursor' as a parameter to the 'test_' functions. -- To view, visit http://gerrit.cloudera.org:8080/8170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If680240a3cd4583fc97c3192177d86d9567c4f8d Gerrit-Change-Number: 8170 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Oct 2017 18:11:44 +0000 Gerrit-HasComments: Yes
