Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 )
Change subject: IMPALA-5789: Add always_false flag in bloom filter ...................................................................... Patch Set 4: (3 comments) I need to do a proper pass over this. Did a quick pass now and had some questions. http://gerrit.cloudera.org:8080/#/c/8170/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/8170/4/be/src/runtime/coordinator.cc@a20 PS4, Line 20: Thanks for doing cleanup here. How did you determine which includes were needed? Is there a good tool to use? http://gerrit.cloudera.org:8080/#/c/8170/4/be/src/runtime/runtime-filter-ir.cc File be/src/runtime/runtime-filter-ir.cc: http://gerrit.cloudera.org:8080/#/c/8170/4/be/src/runtime/runtime-filter-ir.cc@27 PS4, Line 27: if (UNLIKELY(bloom_filter_->AlwaysFalse())) return false; Won't these branches be likely in some cases? IMO best to only use these annotations when it's very strongly unlikely, e.g. error paths. http://gerrit.cloudera.org:8080/#/c/8170/4/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/8170/4/be/src/util/bloom-filter.h@200 PS4, Line 200: if (UNLIKELY(always_false_)) return false; Doesn't this mean that RuntimeFilter::Eval() checks always_false_ twice? Maybe best to only check it in here. -- To view, visit http://gerrit.cloudera.org:8080/8170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If680240a3cd4583fc97c3192177d86d9567c4f8d Gerrit-Change-Number: 8170 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Oct 2017 01:07:19 +0000 Gerrit-HasComments: Yes
