Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8327 )
Change subject: IMPALA-6073: Fail on misconfigured CLASSPATH. ...................................................................... Patch Set 1: (3 comments) Thanks for fixing, lgtm, only minor nits http://gerrit.cloudera.org:8080/#/c/8327/1/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/8327/1/be/src/common/init.cc@178 PS1, Line 178: char *classpath = getenv("CLASSPATH"); style: char* http://gerrit.cloudera.org:8080/#/c/8327/1/be/src/common/init.cc@179 PS1, Line 179: assert(classpath != NULL); Why not DCHECK and add a message http://gerrit.cloudera.org:8080/#/c/8327/1/be/src/common/init.cc@182 PS1, Line 182: assert(std::string(classpath).find("*") == std::string::npos); DCHECK and include an error message -- To view, visit http://gerrit.cloudera.org:8080/8327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb92fa5cad8bbc29b620bec5904e45ed7aeff13d Gerrit-Change-Number: 8327 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Oct 2017 03:45:24 +0000 Gerrit-HasComments: Yes
