Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8327 )
Change subject: IMPALA-6073: Fail on misconfigured CLASSPATH. ...................................................................... Patch Set 1: Code-Review-1 > Patch Set 1: > > > I think this check seems not to be enough. Let me leave a detailed > > comment on the JIRA ticket. > > It is OK to leave detailed comments here in the code review tool. In fact, it > is common. On JIRA, Kim Jin Chul said: > CLASSPATH should be set after loading impala-config.sh but the variable may > not have sufficient libraries. I'm -1'ing this for a bit; I think the trick is to figure out if we can get rid of impala-config.sh setting this at all. I'll try it out. -- To view, visit http://gerrit.cloudera.org:8080/8327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb92fa5cad8bbc29b620bec5904e45ed7aeff13d Gerrit-Change-Number: 8327 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Oct 2017 21:06:23 +0000 Gerrit-HasComments: No
