Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 )
Change subject: IMPALA-4236: Codegen CopyRows() for select nodes ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/8196/8/be/src/exec/select-node.cc File be/src/exec/select-node.cc: http://gerrit.cloudera.org:8080/#/c/8196/8/be/src/exec/select-node.cc@a69 PS8, Line 69: : > Why are these not needed anymore ? Done http://gerrit.cloudera.org:8080/#/c/8196/8/be/src/exec/select-node.cc@72 PS8, Line 72: Status( > Will it be sufficient to use Status::Expected() for this ? I believe finalize function does not fail frequently, so shouldn't affect perf if it writes to log. Also if it ever does fail, its probably worth printing the stacktrace to the logs. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/8196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d496d004418468e16b6f564f90f45ebbf87c1e Gerrit-Change-Number: 8196 Gerrit-PatchSet: 8 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 23:03:37 +0000 Gerrit-HasComments: Yes
