Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 )
Change subject: IMPALA-4236: Codegen CopyRows() for select nodes ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/8196/8/be/src/exec/select-node.cc File be/src/exec/select-node.cc: http://gerrit.cloudera.org:8080/#/c/8196/8/be/src/exec/select-node.cc@72 PS8, Line 72: Status( > It's probably quite clear what the call path is since this is the codegen f both the message in the Status obj created and the information logged by VerifyFunction() provide context related to the failed finalize call. http://gerrit.cloudera.org:8080/#/c/8196/9/tests/query_test/test_codegen.py File tests/query_test/test_codegen.py: http://gerrit.cloudera.org:8080/#/c/8196/9/tests/query_test/test_codegen.py@52 PS9, Line 52: assert_codegen_enabled(result.runtime_profile, [1]) > Optionally, you can consider adding a test in which codegen fails. Not stri Do we already have tests that check for codegen failed? Also is there a way I can induce a failure in codegen? -- To view, visit http://gerrit.cloudera.org:8080/8196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d496d004418468e16b6f564f90f45ebbf87c1e Gerrit-Change-Number: 8196 Gerrit-PatchSet: 9 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Oct 2017 20:45:53 +0000 Gerrit-HasComments: Yes
