Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 )
Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows ...................................................................... Patch Set 2: (5 comments) The code change looks good, just needs a bit more cleanup. http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/exec/partitioned-hash-join-node.h File be/src/exec/partitioned-hash-join-node.h: http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/exec/partitioned-hash-join-node.h@482 PS2, Line 482: output_null_aware_probe_rows_running Needs underscore on end. http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/exec/partitioned-hash-join-node.cc@948 PS2, Line 948: if (!got_reservation) return NullAwareAntiJoinError(null_build_stream); The stream is pinned so this should be impossible - let's make it a DCHECK. http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/exec/partitioned-hash-join-node.cc@1073 PS2, Line 1073: if (!got_reservation) return NullAwareAntiJoinError(build); Same here - got_reservation should always be true for a pinned stream. http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/runtime/buffered-tuple-stream.h File be/src/runtime/buffered-tuple-stream.h: http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/runtime/buffered-tuple-stream.h@127 PS2, Line 127: or GetRows() There are some references to GetRows() in the comments that can be cleaned up too. http://gerrit.cloudera.org:8080/#/c/8226/2/be/src/runtime/buffered-tuple-stream.h@371 PS2, Line 371: friend class SimpleTupleStreamTest_TestGetRowsOverflow_Test; This test was removed too. -- To view, visit http://gerrit.cloudera.org:8080/8226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3831c38994da2b69775a9809ff01de5d23584414 Gerrit-Change-Number: 8226 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Oct 2017 22:35:53 +0000 Gerrit-HasComments: Yes
