Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 )
Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.h File be/src/exec/partitioned-hash-join-node.h: http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.h@482 PS4, Line 482: bool output_null_aware_probe_rows_running_; > Longer-term we should think about ways to reduce the sheer number of statef Yeah many of the members are just used by one state. I think we should summarize the states into enums or put the stateful members into std::variant/boost::variant altogether. http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc@949 PS4, Line 949: RowBatch null_build_batch(child(1)->row_desc(), state->batch_size(), mem_tracker()); > This can fit on one line. Done http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc@962 PS4, Line 962: RETURN_IF_CANCELLED(state); > We should add a RETURN_IF_CANCELLED() check here, similar to the one below Done http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc@1074 PS4, Line 1074: RowBatch build_batch(child(1)->row_desc(), state->batch_size(), mem_tracker()); > This can fit on one line. Done -- To view, visit http://gerrit.cloudera.org:8080/8226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3831c38994da2b69775a9809ff01de5d23584414 Gerrit-Change-Number: 8226 Gerrit-PatchSet: 5 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Oct 2017 22:55:08 +0000 Gerrit-HasComments: Yes
