Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 )
Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8311/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/8311/2/be/src/exprs/expr-test.cc@5959 PS2, Line 5959: "cast(trunc(cast('2012-09-10 01:02:03' as timestamp), 'DAY') as string)", > I don't think the additional test cases add any value unless you add greate Done http://gerrit.cloudera.org:8080/#/c/8311/2/common/thrift/Exprs.thrift File common/thrift/Exprs.thrift: http://gerrit.cloudera.org:8080/#/c/8311/2/common/thrift/Exprs.thrift@92 PS2, Line 92: MILLISECONDS, > We shouldn't have redundant field definitions here; instead we should be le I think we need them even though they look like redundant. See my comment at line 194: https://gerrit.cloudera.org/#/c/8311/2/be/src/exprs/udf-builtins-ir.cc -- To view, visit http://gerrit.cloudera.org:8080/8311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If23ea310ddcc5c1c806b2b1ac24d24a4bd6aa4d9 Gerrit-Change-Number: 8311 Gerrit-PatchSet: 3 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Oct 2017 09:43:49 +0000 Gerrit-HasComments: Yes
