Hello Greg Rahn, Zach Amsden, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8311 to look at the new patch set (#4). Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC ...................................................................... IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC Return type of EXTRACT/DATE_PART is changed from INT to BIGINT because INT data type cannot cover NANOSECOND's value. * Add the following fields to EXTRACT and DATE_PART: WEEK DOW DOY SECOND/SECONDS MICROSECOND/MICROSECONDS NANOSECOND/NANOSECONDS * Add the following field to TRUNC: SS * Testing: Extend unit tests in expr-test Change-Id: If23ea310ddcc5c1c806b2b1ac24d24a4bd6aa4d9 --- M be/src/exprs/expr-test.cc M be/src/exprs/udf-builtins-ir.cc M be/src/exprs/udf-builtins.cc M be/src/exprs/udf-builtins.h M common/function-registry/impala_functions.py M common/thrift/Exprs.thrift 6 files changed, 210 insertions(+), 84 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/8311/4 -- To view, visit http://gerrit.cloudera.org:8080/8311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If23ea310ddcc5c1c806b2b1ac24d24a4bd6aa4d9 Gerrit-Change-Number: 8311 Gerrit-PatchSet: 4 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com>