Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. ...................................................................... Patch Set 16: (9 comments) http://gerrit.cloudera.org:8080/#/c/8202/16/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/8202/16/be/src/service/impala-server.h@105 PS16, Line 105: /// TODO: The state of a running query is currently not cleaned up if the > Let's document the startup procedure and the reasoning behind it here Done http://gerrit.cloudera.org:8080/#/c/8202/16/be/src/service/impala-server.h@1014 PS16, Line 1014: /// Flag that records if backend and/or client services have been started. > Clarify the meaning of "and/or" here. The distinction seems important. Will clarified the comment. we can use "is_ready", but I think of metrics as a view on internal state, so I'd prefer to not have internal state depend on them. any preferences on the topic? http://gerrit.cloudera.org:8080/#/c/8202/16/be/src/service/impala-server.h@1017 PS16, Line 1017: boost::mutex services_started_lock_; > std::atomic_bool instead of this lock? Done http://gerrit.cloudera.org:8080/#/c/8202/16/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8202/16/be/src/service/impala-server.cc@1626 PS16, Line 1626: // Register this backend only if services have been started. > Feels clearer to me to check this at the caller. Can be hard to reason abou had it at the caller before-- agreed that its clearer there. http://gerrit.cloudera.org:8080/#/c/8202/16/be/src/service/impala-server.cc@1933 PS16, Line 1933: Status ImpalaServer::Init(int32_t thrift_be_port, int32_t beeswax_port, > Why reformat fn args? Seemed ok the way it was. Done http://gerrit.cloudera.org:8080/#/c/8202/16/tests/custom_cluster/test_catalog_wait.py File tests/custom_cluster/test_catalog_wait.py: http://gerrit.cloudera.org:8080/#/c/8202/16/tests/custom_cluster/test_catalog_wait.py@24 PS16, Line 24: """Impalad must wait for the catalog prior to opening up client ports. > Specify the waiting condition more precisely. An impalad must wait for the Done http://gerrit.cloudera.org:8080/#/c/8202/16/tests/custom_cluster/test_catalog_wait.py@54 PS16, Line 54: self.expect_connection(self.cluster.impalads[0]) > Ideally we'd also check the internal service added a comment when issuing a query. a query will catch two cases: (1) impalad registered prematurely is caught by query fragment metrics and (2) query failure if the impalad registered as a backend but could not run a fragment. http://gerrit.cloudera.org:8080/#/c/8202/16/tests/custom_cluster/test_catalog_wait.py@59 PS16, Line 59: def test_query_subset(self): > Can we combine this test wit the one above? They seem very similar Done http://gerrit.cloudera.org:8080/#/c/8202/16/tests/custom_cluster/test_catalog_wait.py@71 PS16, Line 71: self.cluster.impalads[0].service.get_metric_value('impala-server.ready', 1); > I'm wondering whether this can be flaky. We often use self.wait_for_metric_ Done -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 16 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Oct 2017 07:19:57 +0000 Gerrit-HasComments: Yes
