Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 )
Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test File testdata/workloads/tpcds/queries/tpcds-q26.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test@3 PS4, Line 3: -- RESULT MISMATCH FROM ORIGINAL Please use a more descriptive comment. What kind of mismatch? Which column? Description of mismatch. http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test@4 PS4, Line 4: -- TAKE ACTUAL RESULT AS EXPECTED What does this mean? http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q47.test File testdata/workloads/tpcds/queries/tpcds-q47.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q47.test@3 PS4, Line 3: -- RESULT MISMATCH FROM ORIGINAL in LSD of DECIMAL values Would be good to use an example to better describe the mismatch http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q59.test File testdata/workloads/tpcds/queries/tpcds-q59.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q59.test@3 PS4, Line 3: Remove line http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q63.test File testdata/workloads/tpcds/queries/tpcds-q63.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q63.test@3 PS4, Line 3: Remove line -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Nov 2017 22:35:01 +0000 Gerrit-HasComments: Yes
