Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 )
Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE ...................................................................... Patch Set 5: (2 comments) Do you have 3 runs showing that there is no new flaky test cases? http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q77a.test File testdata/workloads/tpcds/queries/tpcds-q77a.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q77a.test@4 PS5, Line 4: -- FIXED. USE ACTUAL RESULT AS EXPECTED RESULT Please add explanation for what was different. http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q86a.test File testdata/workloads/tpcds/queries/tpcds-q86a.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q86a.test@4 PS5, Line 4: -- FIXED. USE ACTUAL RESULT AS EXPECTED RESULT What was the difference? -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 14 Nov 2017 00:43:14 +0000 Gerrit-HasComments: Yes
