Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. ...................................................................... Patch Set 19: (5 comments) http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/frontend.h File be/src/service/frontend.h: http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/frontend.h@162 PS19, Line 162: Sets the FE catalog to be initialized. I don't understand what that's trying to say. http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/impala-server.h@79 PS19, Line 79: The executor role starts ImpalaInternalService API's technically the coordinator also has to start the ImpalaInternalService API in order to run the coordinator fragment instance. http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/impala-server.h@89 PS19, Line 89: must call the following : /// methods: why is this split into two steps? Is there something the caller would want to do between opening the ports and starting the services? http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/impala-server.cc@1518 PS19, Line 1518: nit: indentation glitch http://gerrit.cloudera.org:8080/#/c/8202/19/be/src/service/impala-server.cc@1937 PS19, Line 1937: RETURN_IF_ERROR(exec_env_->StartServices()); why does this have to be moved so early? i'm not sure if this will cause problems when krpc is enabled. -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 19 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Nov 2017 23:22:56 +0000 Gerrit-HasComments: Yes
