Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. ...................................................................... Patch Set 22: Code-Review+2 (7 comments) Minor formatting nits. Tests seem reasonable to me. http://gerrit.cloudera.org:8080/#/c/8202/22/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8202/22/be/src/service/impala-server.cc@1930 PS22, Line 1930: int32_t hs2_port) { fix indentation http://gerrit.cloudera.org:8080/#/c/8202/22/be/src/service/impala-server.cc@1948 PS22, Line 1948: ; remove http://gerrit.cloudera.org:8080/#/c/8202/22/be/src/service/impala-server.cc@1980 PS22, Line 1980: boost::shared_ptr<TProcessor> beeswax_processor(new ImpalaServiceProcessor(handler)); nit: long line http://gerrit.cloudera.org:8080/#/c/8202/22/be/src/service/impalad-main.cc File be/src/service/impalad-main.cc: http://gerrit.cloudera.org:8080/#/c/8202/22/be/src/service/impalad-main.cc@88 PS22, Line 88: FLAGS_hs2_port nit: indentation http://gerrit.cloudera.org:8080/#/c/8202/22/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/8202/22/bin/start-impala-cluster.py@316 PS22, Line 316: """Waits for a catalog copy to be received by the impalad. When its received, additionally nit: long line http://gerrit.cloudera.org:8080/#/c/8202/22/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/8202/22/tests/common/custom_cluster_test_suite.py@125 PS22, Line 125: cluster_size=CLUSTER_SIZE, num_coordinators=NUM_COORDINATORS, : use_exclusive_coordinators=False, log_level=1, : expected_num_executors=CLUSTER_SIZE): indentation http://gerrit.cloudera.org:8080/#/c/8202/22/tests/custom_cluster/test_catalog_wait.py File tests/custom_cluster/test_catalog_wait.py: http://gerrit.cloudera.org:8080/#/c/8202/22/tests/custom_cluster/test_catalog_wait.py@81 PS22, Line 81: # TODO: add more tests : # - impalads that are just coordinators : # - impalads that are just executors : # - process reincarnation, e.g., healthy impalad crashes and is restarted remove -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 22 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Nov 2017 07:00:58 +0000 Gerrit-HasComments: Yes
