Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 )
Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc@797 PS4, Line 797: reader->disk_states_[disk_queue->disk_id].DecrementRequestThread(); > That's a good question. I don't understand whether it's a bug or not. It's I spent some more time looking at this and I'm increasingly thinking that this isn't the right way to propagate the error. I've been looking at how other errors are propagated to clients and it's deeply weird - I think it somehow depends on the cancelled scan range being repeatedly scheduled until the request context is cancelled. -- To view, visit http://gerrit.cloudera.org:8080/8414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5cb42437d11c13bc4a55c3ab426b66777332bd1 Gerrit-Change-Number: 8414 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Nov 2017 22:23:55 +0000 Gerrit-HasComments: Yes
