Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 )
Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt ...................................................................... Patch Set 7: (3 comments) I kept on pulling at the error propagation string and I've realised that we need a few more changes to get this into a good state where it's more clearly correct. I'm going to continue working on that and post a patchset once I'm done. http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc@797 PS4, Line 797: > So is the fix here still correct? Here only a range is cancelled and the cl I don't think it's correct. I also realised that the error propagation is weird and could be simplified, so I'm going to simplify both things in a new patchset. http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/exec-env.cc@38 PS7, Line 38: #include "runtime/io/disk-io-mgr.h" > include order Done http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/io/disk-io-mgr-stress.cc File be/src/runtime/io/disk-io-mgr-stress.cc: http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/io/disk-io-mgr-stress.cc@204 PS7, Line 204: if (clients_[i].reader != nullptr) { > Is it possible? ClientThread set reader to NULL in L165. Done -- To view, visit http://gerrit.cloudera.org:8080/8414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5cb42437d11c13bc4a55c3ab426b66777332bd1 Gerrit-Change-Number: 8414 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Nov 2017 19:28:51 +0000 Gerrit-HasComments: Yes
