LebronAl commented on a change in pull request #1457:
URL: https://github.com/apache/incubator-iotdb/pull/1457#discussion_r449750891
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/query/ClusterPlanExecutor.java
##########
@@ -707,5 +709,24 @@ public void delete(Path path, long timestamp) throws
QueryProcessException {
}
}
+ @Override
+ public void delete(DeletePlan deletePlan) throws QueryProcessException {
+ try {
+ Set<String> existingPaths = new HashSet<>();
+ for (Path p : deletePlan.getPaths()) {
+ existingPaths.addAll(getPathsName(p.getFullPath()));
+ }
+ if (existingPaths.isEmpty()) {
+ logger.info("TimeSeries does not exist and its data cannot be
deleted");
+ return;
Review comment:
This change surely can abandon unnecessary exception, but what if the
user deletes a time series which really doesn't exist? I think distributed
IoTDB should also throw an exception to user as same as stand-alone IoTDB.
Maybe you should add a judgement in `processNonPartitionedDataPlan` after
getting all paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
