[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1457: delete timeseries when path is not found

[GitBox]

Ring-k commented on a change in pull request #1457:
URL: https://github.com/apache/incubator-iotdb/pull/1457#discussion_r449761431



##########
File path: 
cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
##########
@@ -1510,6 +1511,32 @@ private TSStatus 
processNonPartitionedMetaPlan(PhysicalPlan plan) {
    * @return
    */
   private TSStatus processNonPartitionedDataPlan(PhysicalPlan plan) {
+    if(plan instanceof DeleteTimeSeriesPlan){
+      List<Path> originalPaths = ((DeleteTimeSeriesPlan)plan).getPaths();

Review comment:
       Thank you for your reminding :)

##########
File path: 
cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
##########
@@ -1510,6 +1511,32 @@ private TSStatus 
processNonPartitionedMetaPlan(PhysicalPlan plan) {
    * @return
    */
   private TSStatus processNonPartitionedDataPlan(PhysicalPlan plan) {
+    if(plan instanceof DeleteTimeSeriesPlan){
+      List<Path> originalPaths = ((DeleteTimeSeriesPlan)plan).getPaths();
+      ConcurrentSkipListSet<Path> fullPaths = new ConcurrentSkipListSet<>();
+      ExecutorService getAllPathsService = 
Executors.newFixedThreadPool(partitionTable.getGlobalGroups().size());
+      for(Path path : originalPaths){
+        String pathStr = path.getFullPath();
+        getAllPathsService.submit(()->{
+          try {
+            List<String> fullPathStrs = getMatchedPaths(pathStr);
+            for(String fullPathStr : fullPathStrs){
+              fullPaths.add(new Path(fullPathStr));
+            }
+          } catch (MetadataException e) {
+            logger.error("Failed to get full paths of the prefix path: {}", 
pathStr);
+          }
+        });
+      }
+      getAllPathsService.shutdown();
+      try {
+        getAllPathsService.awaitTermination(RaftServer.getQueryTimeoutInSec(), 
TimeUnit.SECONDS);
+      } catch (InterruptedException e) {
+        Thread.currentThread().interrupt();
+        logger.error("Unexpected interruption when waiting for get all paths 
services to stop", e);
+      }
+      ((DeleteTimeSeriesPlan)plan).setPaths(new ArrayList<>(fullPaths));

Review comment:
       Thank you for your reminding :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org