jt2594838 commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566883537
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileOutput.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.storageengine.dataregion.compaction.io; + +import org.apache.iotdb.db.conf.IoTDBDescriptor; +import org.apache.iotdb.db.storageengine.dataregion.compaction.schedule.CompactionTaskManager; +import org.apache.iotdb.tsfile.write.writer.TsFileOutput; + +import com.google.common.util.concurrent.RateLimiter; + +import java.io.IOException; +import java.io.OutputStream; +import java.nio.ByteBuffer; + +public class CompactionTsFileOutput extends OutputStream implements TsFileOutput { + + private TsFileOutput output; + private RateLimiter rateLimiter = CompactionTaskManager.getInstance().getMergeWriteRateLimiter(); + private final long maxSizePerWrite; + + public CompactionTsFileOutput(TsFileOutput output) { + this.output = output; + maxSizePerWrite = + (int) + (rateLimiter.getRate() + / IoTDBDescriptor.getInstance().getConfig().getCompactionThreadCount()); Review Comment: I do not see the point. What is so different between waiting for 1 second twice and 2 seconds once? The total waiting time is not affected by the block size. Blocking other threads is also quite normal because you are doing RATE LIMITING and blocking is how exactly things are done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
