jt2594838 commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566891500
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionTaskManager.java: ########## @@ -84,17 +84,19 @@ public class CompactionTaskManager implements IService { private final RateLimiter mergeWriteRateLimiter = RateLimiter.create( - IoTDBDescriptor.getInstance().getConfig().getCompactionWriteThroughputMbPerSec() - * 1024.0 - * 1024.0); + config.getCompactionWriteThroughputMbPerSec() <= 0 + ? Double.MAX_VALUE + : config.getCompactionWriteThroughputMbPerSec()); Review Comment: Should the value be multiplied by 1024*1024? I assume its unit is MB while the RateLimiter's is Byte. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org