chrisdutz commented on code in PR #12914:
URL: https://github.com/apache/iotdb/pull/12914#discussion_r1679197035
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -256,6 +276,24 @@ public TDataNodeRegisterResp
registerDataNode(TDataNodeRegisterReq req) {
@Override
public TDataNodeRestartResp restartDataNode(TDataNodeRestartReq req) {
+ // If the remote server is configured to bind to all ip addresses
(0.0.0.0),
+ // update the request to use the remote address we got this request from.
+ if ((req.dataNodeConfiguration.getLocation() != null)
Review Comment:
Well ... the issue I was trying to fix, was that in the case of 3 dataNodes
joining the cluster, they all will be listed as "0.0.0.0" ... if you then want
to remove it by it's real ip then you will not be able to remove it as it only
finds 0.0.0.0 nodes and if you use 0.0.0.0, you will delete all nodes. So I
think for a 1C1D it should be 127.0.0.1 and not 0.0.0.0 because one is a real
ip and the other one isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
